Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16419/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16419/3//COMMIT_MSG@12 PS3, Line 12: - TODO: I don't think we have good test coverage on this, I tried to > Does the number of partitions and the number of impalads have to be the sam Would it be possible to write a test to call both the non-llvm and the llvm-code to hash a set of values. If so, then we can just compare the hash results. For v in values hash1 = non_llvm(v); hash2 = llvm(v); assert(hash1 == hash2); -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Sep 2020 13:35:21 +0000 Gerrit-HasComments: Yes
