Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 5: Code-Review+1 (1 comment) I think this addresses my concerns. Csaba, feel free to +2 once you're happy with the tests - don't wait for me. http://gerrit.cloudera.org:8080/#/c/16419/5/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/16419/5/tests/query_test/test_kudu.py@570 PS5, Line 570: with self.temp_kudu_table(kudu_client, [INT32], num_partitions=3) as kudu_table: : impala_table_name = self.get_kudu_table_base_name(kudu_table.name) : props = "TBLPROPERTIES('kudu.table_name'='%s')" % kudu_table.name : cursor.execute("CREATE EXTERNAL TABLE %s STORED AS KUDU %s" % ( : impala_table_name, props)) > Do we need the temp_kudu_table + external kudu table pointing to it, couldn I had the same thought, that we could create a managed kudu table instead. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2020 03:45:09 +0000 Gerrit-HasComments: Yes
