Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16419/4/be/src/exec/kudu-util-ir.cc File be/src/exec/kudu-util-ir.cc: http://gerrit.cloudera.org:8080/#/c/16419/4/be/src/exec/kudu-util-ir.cc@54 PS4, Line 54: // TODO: codegen this to eliminate branching on type. > I am not sure if this is still relevant - after this change this function i This function is moved here from kudu-util.cc. This change is not the only place that calls this function (see https://github.com/apache/impala/blob/7b44b351321969fa6a90212f4c9b56c521a85ec4/be/src/exec/kudu-table-sink.cc#L264) and the TODO may still apply there. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2020 12:51:30 +0000 Gerrit-HasComments: Yes
