wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting Iceberg table properties ...................................................................... Patch Set 1: Hi Zoltan, thanks for explain. But I still have some questions. You said that this patch is mainly for Iceberg tables with HiveCatalog which have proper Input/Output format, SerDe. And Impala can load these tables normally even without 'iceberg.catalog'(because HiveCatalog is default catalog type?). If so, I think we only need to enable setting 'iceberg.file_format', because 'iceberg.catalog_location' and 'iceberg.table_identifier' are related to HadoopCatalog instead of HiveCatalog, as for 'iceberg.catalog', we do not need to setting it at all. I not sure if my understanding correct? -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 23 Mar 2021 12:22:18 +0000 Gerrit-HasComments: No
