Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting Iceberg table properties ...................................................................... Patch Set 2: Code-Review+2 (1 comment) I only had a commit msg related comment, otherwise the patch seems fine. http://gerrit.cloudera.org:8080/#/c/17207/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17207/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-10597: Enable setting Iceberg table properties I found the commit msg a bit misleading as I had the impression that more than a single table property is enableb with this commit. As long as it's only one I think you can instead name that particular one in the msg. -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 12:16:32 +0000 Gerrit-HasComments: Yes
