Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting Iceberg table properties ...................................................................... Patch Set 2: Yeah, I was allowing setting these properties just in case users might need it for some reason. But I agree that the other properties are not needed for HiveCatalog tables. Also, if there's a table using another catalog type, then Impala is not able to load the table, there we can't run any ALTER TABLE statements. So yeah, it's probably better to make them "constant" for the life cycle of the table. In the long-term I think we'll probably want to standardise the table properties across the engines anyway. -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 24 Mar 2021 11:07:36 +0000 Gerrit-HasComments: No
