Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting Iceberg table properties ...................................................................... Patch Set 2: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/17207/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/17207/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@32 PS2, Line 32: ALTER TABLE iceberg_hadoop_tables set TBLPROPERTIES('iceberg.file_format'='orc'); As I learnt, if there is already some data being written into the table e.g. in Parquet format, it won't be readable after changing the file format. I think we should consider writing a warning to the user that in case they have data they won't be able to read it. More sophisticated way would be to write this warning only if the table contains data when changing the file format. -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 12:46:44 +0000 Gerrit-HasComments: Yes
