Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting 'iceberg.file_format' ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17207/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/17207/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@171 PS3, Line 171: if (fileformat == null || IcebergUtil.getIcebergFileFormat(fileformat) == null) { Could you please add a test for this as well? http://gerrit.cloudera.org:8080/#/c/17207/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@182 PS3, Line 182: if (!firstFile.format().name().equalsIgnoreCase(fileformat)) { : throw new AnalysisException(String.format(errorMsg, fileformat, firstFile.path(), : firstFile.format().name())); : } Is this part needed? The for loop below would cover the same, right? -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 29 Mar 2021 09:02:40 +0000 Gerrit-HasComments: Yes
