Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17207 )
Change subject: IMPALA-10597: Enable setting 'iceberg.file_format' ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17207/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17207/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-10597: Enable setting Iceberg table properties > I found the commit msg a bit misleading as I had the impression that more t Done http://gerrit.cloudera.org:8080/#/c/17207/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/17207/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@32 PS2, Line 32: ALTER TABLE iceberg_hadoop_tables set TBLPROPERTIES('iceberg.file_format'='orc'); > As I learnt, if there is already some data being written into the table e.g Added additional checks to AlterTableSetTblProperties. -- To view, visit http://gerrit.cloudera.org:8080/17207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b3506be4562a1ace3e6435867aadb3bdde7a8e2 Gerrit-Change-Number: 17207 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 14:41:42 +0000 Gerrit-HasComments: Yes
