Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6843265659
Review update for PR #19051 at head `b16ee048b5d5370c9129b5ab076a00318970079e`. The review found one assertion gap in `IoTDBLoadTsFileBoundaryIT#testInvalidTreeDevicePathFailsWithAndWithoutMiniConversion`: the optional result-row check could skip the mini-conversion mods assertion. The test now requires the successfully converted valid-prefix row, verifies its `quality=7` and `value=NULL` after mods, and requires the normal-analysis failure path to produce no row. The other scoped LOAD boundary, mixed-model, Pipe marker, and table-device batch tests had no confirmed issue. Verification: Spotless passed, and the staged diff passed `git diff --cached --check`. The new ITs were not run; prior validation attempts were blocked before test execution by Maven dependency resolution and a compile error in an unchanged source file. PR remains Draft pending a fresh independent review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
