Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6647480213
<!-- metadata-it-selection-20261105-325dd94bde3 --> ### Metadata IT selection and target validation The single local re-review covered the requested metadata IT diff at `8d7dbf3ca6e94b1bfbebe9002ee7cf20ec5947d6` plus the working changes, including earlier repairs. The subsequent requested rerun and transfer validation found the following concrete target issues and fixed them: - **P1 — `integration-test/pom.xml:99`:** direct ASM test scope excluded cglib's ASM dependency from ordinary child-node templates, causing `NoClassDefFoundError: org/objectweb/asm/Type`. The instrumented agent supplied ASM itself and hid this startup issue. ASM now has runtime scope in the IT module. - **P2 — `MetadataFaultController.java:59`:** the source fixture's environment-variable APIs do not exist on this target branch, causing IT test compilation to fail. The controller now uses the existing `MppJVMConfig` JVM options API and restores the prior options. No production source or production test hook was added. The transfer now retains only `testOldRemoteFetchCannotRefillStaleAttributes` and the strengthened `testDropTableModFileProgress`, with their test-only fault scaffolding. Four failing propagation scenarios and the complete parameterized TagAlter addition remain outside the PR update. The SchemaRegion migration method passed the source rerun but failed on the target at `IoTDBTableTagSchemaMigrationIT.java:222`, where `DELETE DEVICES` returned a null `TDataNodeLocation` error; its entire new class has been withdrawn from the PR. These failures were preserved without assigning an unproven product/IT cause or weakening assertions. Validation on Linux / OpenJDK 17 / Maven 3.8.8: - TableClusterIT executed 3 methods: both retained methods passed; the now-excluded migration method errored. The broader Maven command exited 1. - TableSimpleIT executed DROP/MOD: **1 passed, 0 failures, 0 errors, 0 skipped**, Maven exit 0. The final retained selection therefore has **3 passing configurations**. - Required IoTDB modules were initially rebuilt from clean source in an isolated reactor/repository. Focused follow-ups reused the same source-built dependencies under recorded provenance; this was not a fresh uncached full build. All five final retained paths match the executed source hashes. - Scoped Spotless, source-selection and whitespace checks passed. Existing module Checkstyle is ineffective because its exclusion expression has an empty alternative and was left unchanged. The full IT suite and Chinese locale were not run. Reviewed source SHA: `8d7dbf3ca6e94b1bfbebe9002ee7cf20ec5947d6` plus the working diff. Final local candidate SHA and confirmed remote branch/PR head: `325dd94bde3ea8aaf9cc47b28484df26a1f9aaa3`. Publication and head confirmation are complete. The PR remains **Draft**. A fresh session must independently review the full current PR diff and relevant context at the latest remote head; no second complete review was performed in this session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
