Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6622563519
Scoped independent re-review of commit 906980acc9064627a01ac64dfb052c488086ea5b against parent 339f1074518b0a611f86f9a094250b62a8e86942, limited to the two table metadata recovery IT files and necessary context. No in-scope issue was found and no code changes were needed.\n\nThe P0 test's bounded pre-fault wait polls all three DataNode SQL endpoints. The TTL test's two replication barriers enumerate each actual DataRegion replica and wait for IoTConsensus synchronization, covering both the pre-shutdown fixture and final post-recovery writes. The TTL assertions correctly distinguish the creation-time database TTL copied by existing tables from the explicit table TTL change. The auto-sync reproducer remains ignored because the current property validation rejects uto_sync_schema; it is a documented coverage gap, not passing test coverage.\n\nVerification: no tests were rerun in this round. The retained clean Linux/JDK 17 TableClusterIT, 3CN/3DN record shows the TTL method ran with 1 test, 0 failures, 0 errors, 0 skipped and Maven exit 0. P0 was unchanged and not rerun; its prior focused pass is historical evidence. Auto-sync remains skipped.\n\nReviewed SHA: 906980acc9064627a01ac64dfb052c488086ea5b. Final local SHA: 906980acc9064627a01ac64dfb052c488086ea5b. Source branch and PR head confirmed at the same SHA. PR Draft status was left unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
