Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6651185869
Scoped independent re-review of the complete net diff from `906980acc9064627a01ac64dfb052c488086ea5b` through `a4208745f6fb41dad91886f6efbf523cd39b6633`, including earlier fixes, strictly limited to: - `integration-test/pom.xml` - `integration-test/src/test/java/org/apache/iotdb/relational/it/schema/IoTDBDropTableModProgressIT.java` - `integration-test/src/test/java/org/apache/iotdb/relational/it/schema/IoTDBTableMetadataPropagationIT.java` - `integration-test/src/test/java/org/apache/iotdb/relational/it/schema/fault/MetadataFaultAgent.java` - `integration-test/src/test/java/org/apache/iotdb/relational/it/schema/fault/MetadataFaultController.java` No actionable defect was confirmed in this scoped round. Necessary production context was read without modification. Other PR changes and withdrawn scenarios were excluded. A candidate concern about the post-recreation LAST warm-up was investigated and rejected. `TableDeviceSchemaCache.updateLastCacheIfExists` deliberately updates only existing cache entries; querying an empty table does not initialize LAST entries for a device that does not yet exist. Removing the original post-insert warm-up incorrectly required the first write to populate a cold cache. That experimental candidate ran one test with one assertion failure (`CachedDeviceNumber: 0`) and was discarded. The file was restored exactly to the reviewed head; all original assertions remain. Validation: - The unchanged reviewed head passed the focused Windows/JDK 17 `TableSimpleIT` run of `IoTDBDropTableModProgressIT#testDropTableModFileProgress`: **1 test, 0 failures, 0 errors, 0 skips; Maven exit 0**, confirmed from Failsafe XML. IT outputs were cleaned, and required reactor dependencies came from this session's matching-source build with build-cache reuse disabled. - Earlier remote preparation attempts stopped before Maven because of source-fetch TLS errors; no tests ran in those attempts. This round did not rerun the cluster profile. The previously reported Linux/JDK 17 focused cluster pass remains prior verification evidence. - IT compilation, scoped Spotless, and whitespace checks passed. All newly added tests had already been run locally in the supplied verification background. Full IT coverage, the Chinese locale, and hosted CI remain unverified. The existing ineffective IT Checkstyle exclusion was left unchanged and is not counted as validation. No code changes, commits, or pushes were retained. Final local HEAD, confirmed `apache/iotdb:test/pipe-p0-it-master` HEAD, and PR HEAD are all `a4208745f6fb41dad91886f6efbf523cd39b6633`; no concurrent head update was observed. The PR remains **Draft** as requested. These conclusions apply only to the five-file scope above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
