Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6681423801
Scoped independent review of commit `125c9659a8f81c643462b2a51fa7e8867f5bf601` (parent `989dd054fc3a0269f30c24988837ef9d09b51f4e`), limited to `IoTDBPipeTransferRecoveryIT.java` and necessary configuration/startup context. This does not review or approve the full PR. No actionable issue was found. In [the changed setup](https://github.com/apache/iotdb/blob/125c9659a8f81c643462b2a51fa7e8867f5bf601/integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/auto/enhanced/IoTDBPipeTransferRecoveryIT.java#L105-L117), each environment is configured with Schema/Data replication factors of 1 before `initClusterEnvironment(1, 1)`. The Pipe CI job selects `HighPerformanceMode` for both clusters, and that preset specifies replication factors 3 and 2. `MppSharedCommonConfig` applies the setters to both ConfigNode and DataNode common configs; `AbstractNodeWrapper.changeConfig` applies preset properties before developer-mutated config values. The explicit values therefore take effect for both one-DataNode environments before startup. The commit changes fixture setup only. All six test methods, recovery actions, and assertions remain unchanged, so this topology correction does not remove an existing recovery assertion. Validation available for this round: Windows/JDK 17 focused clean verify with `HighPerformanceMode,HighPerformanceMode`; 6 tests passed, 0 failures, 0 errors, 0 skipped; Maven exit code 0. Linux, the full suite, and the Chinese build were not verified. No new test was added by this commit. Reviewed commit and final local reviewed revision: `125c9659a8f81c643462b2a51fa7e8867f5bf601`. The confirmed `test/pipe-p0-it-master` source branch and PR head match that SHA. No code changes were needed, and the PR remains Draft. These conclusions apply only to this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
