Caideyipi commented on PR #19051:
URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6649517800

   ## Independent re-review (metadata IT scope only)
   
   Reviewed the requested three-commit net change from 
`906980acc9064627a01ac64dfb052c488086ea5b` through 
`325dd94bde3ea8aaf9cc47b28484df26a1f9aaa3`, plus the review fix at 
`a4208745f6fb41dad91886f6efbf523cd39b6633`, limited to the five metadata IT 
files. This result does not indicate that the full PR passed.
   
   - **Finding fixed:** After releasing the held old fetch, the follow-up SQL 
assertion could fetch and refill a missing cache entry, masking an incorrect 
cache state. The test now reads the target node's attribute cache directly 
first and requires `d1.changing` to be present with value `current` before 
issuing SQL assertions.
   - **Verification:** On Linux/OpenJDK 17, a clean `TableClusterIT` reactor 
run for 
`IoTDBTableMetadataPropagationIT#testOldRemoteFetchCannotRefillStaleAttributes` 
completed with `BUILD SUCCESS`; the report recorded 1 test, 0 failures, 0 
errors, and 0 skipped. Scoped compile, Spotless, and whitespace checks also 
passed. A separate attempt ended before tests during Maven dependency 
resolution (`Connection reset` retrieving `extra-enforcer-rules:1.12.1`). The 
previously reported broader cluster run still exits 1 on the withdrawn 
SchemaRegion migration test; it is outside this review selection. Full IT, 
Chinese-locale build, and hosted CI were not verified.
   
   The source branch and PR HEAD both match 
`a4208745f6fb41dad91886f6efbf523cd39b6633`; the PR remains Draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to