Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS1, Line 135: vector<string> > static const? Done Line 135: vector<string> common_locations = { > See my earlier comment in FindKdc.cmake about additional locations. Done http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.h File src/kudu/security/mini_kdc.h: Line 46: class MiniKdc { > Nit: if we want to be consistent with cluster class naming, I'd suggest Ext I don't think it's going to cause much confusion, e.g. it hasn't been a problem for Java's mini cluster. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
