Alexey Serbin has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 33: If kdc is not found, it does not make sense to build and run those. So, consider either making these optional by the presence of the krb-related binaries, or requiring kdc to be present. http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS1, Line 276: "-q" > One thing that is a little strange is that everything after the -q has to b nope, I was just running these commands (without '-q') manually while going trough some tutorials and then I saw this change and decided to try it. OK, my mistake was not quoting the query -- after I did it, that worked for me. Thank you for the clarification. http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS3, Line 67: in_argv) { Instead, consider using 'ccache_name' parameter for the particular realms or 'default_ccache_name' for libdefaults PS3, Line 183: } It seems my comment is left among those for PS1, but I'll just re-iterate it here: it's possible to avoid listening on UDP ports by kdc_ports = "" Otherwise, TCP and UDP ports are different in case of binding to ephemeral ones. PS3, Line 220: This is not needed if using kdc_ports = "" in krb5.conf PS3, Line 287: The '-q' option does not work in case of my installation of krb5 using MacPorts. Is it possible to get rid of this '-q'? Does it work without it? -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
