Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 33: ADD_KUDU_TEST(mini_kdc-test) > If kdc is not found, it does not make sense to build and run those. So, co I don't think it's viable in the long term to limit tests requiring KDC, nor do I think disabling security tests is desirable. http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS3, Line 67: KRB5CCNAME=$0 > Instead, consider using 'ccache_name' parameter for the particular realms o See revision 4. PS3, Line 183: kdc_ports = $2 > It seems my comment is left among those for PS1, but I'll just re-iterate i See revision 4. PS3, Line 220: udp_preference_limit = 0 > This is not needed if using kdc_ports = "" in krb5.conf I think we still want this, otherwise the client will prefer connecting to the KDC via UDP. PS3, Line 287: "-q" > The '-q' option does not work in case of my installation of krb5 using MacP See my reply on the previous revision. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
