Alexey Serbin has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS1, Line 60: KRB5_CCNAME > Should it be KRB5CCNAME instead? Also, what about using configuration parameter 'default_ccache_name' in krb5.conf instead? PS1, Line 171: kdc_ports = 0 If you want, it's possible to disable UDP ports at all via setting kdc_ports = "" PS1, Line 206: udp_preference_limit See my previous comment on disabling UDP ports. PS1, Line 276: "-q" BTW, with the '-q' options it doesn't work for me on MacOS X krb5 if adding a principal. It even does not work for me for get_principal. It seems MacPort version of krb5 (1.14.3) and brew's version is different a bit. I'm curios: what if we drop the '-q' option? Would it work for Linux and briew krb5? -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
