Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4752/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 908: find_package(Kdc) > OK, I see -- but that means the KDC-related tests should be run only if thi > OK, I see -- but that means the KDC-related tests should be run only if this > is found, otherwise it doesn't make sense to run those. I disagree, I think its important that security tests always get run. Additionally, it's probably not going to be the case for very long that tests which rely on security are going to be kept separate. Eventually we will want to switch all tests to use security by option or by default. http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS1, Line 171: kdc_ports = 0 > If you want, it's possible to disable UDP ports at all via setting Done PS1, Line 206: udp_preference_limit > See my previous comment on disabling UDP ports. Done PS1, Line 276: "-q" > BTW, with the '-q' options it doesn't work for me on MacOS X krb5 if adding One thing that is a little strange is that everything after the -q has to be in quotes, like: kadmin.local -q "add_principal -pw dan dan" Is the test failing on your machine? -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
