Alexey Serbin has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4752/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 908: find_package(Kdc) > I don't think it's appropriate to fail the build if KDC can't be found. Ad OK, I see -- but that means the KDC-related tests should be run only if this is found, otherwise it doesn't make sense to run those. If we are interested in krb binaries, then it's fine. Using pkgconfig would make more sense if trying to find non-standard locations of libraries/header files. For binaries, packages have exec_prefix, so it's possible to find binaries as well, as I understand. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
