Todd Lipcon has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 4665: MonoDelta block_interval) { to make this less timing-dependent, why not take in a CountdownLatch to wait on? then the test can just countdown the latch after the first timeout? PS2, Line 4688: thread(bind(&BlockCatalogManager, : catalog, : MonoDelta::FromSeconds(2))).detach(); : might be fewer overall lines just to use a lambda here http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 153: Status MiniMaster::StartDistributedMasterOnPorts(uint16_t rpc_port, uint16_t web_port, this is a little hard to review because you moved the function while changing it - can't see side by side diff of what changed. can you put it back in its old position? http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/master/mini_master.h File src/kudu/master/mini_master.h: PS2, Line 59: // The Init() and StartInitted() methods below are used to separate : // execution of Master::Init() and Master::StartAsync() methods, : // so it's possible to tinker with the master object in between. : Status Init(uint16_t rpc_port = 0); : Status StartInitted(); can you clarify in the docs here that the combination of these two, in this order, are equivalent to the normal "Start()' call? maybe 'StartAlreadyInitted()' would be a clearer name as well -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
