Alexey Serbin has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 4665: MonoDelta block_interval) { > to make this less timing-dependent, why not take in a CountdownLatch to wai I want the second request to start when the catalog manager is still blocked -- want to see it ends as a success. PS2, Line 4688: thread(bind(&BlockCatalogManager, : catalog, : MonoDelta::FromSeconds(2))).detach(); : > might be fewer overall lines just to use a lambda here Do you mean lambda for the function to be called by the thread? I tried that but it didn't work -- compilation error. Probably, should have used 'static' or something like that for the lambda variable. http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 153: Status MiniMaster::StartDistributedMasterOnPorts(uint16_t rpc_port, uint16_t web_port, > this is a little hard to review because you moved the function while changi ok, will do. -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
