Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@231 PS10, Line 231: stale The 'stale' terminology hasn't been introduced here, so I think it would be best to avoid it. Perhaps 'two READ_YOUR_WRITES scans, ...' http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@233 PS10, Line 233: inconsistent I think it would be better to say 'different results' here in order to avoid confusion over the formal consistency guarantees. http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@237 PS10, Line 237: READ_YOUR_WRITES = 3; It may be good to add docs about whether a snapshot timestamp and propagated timestamp are returned, and what the client should do with them. I'm surprised to see in the latest revision that READ_YOUR_WRITES doesn't return a snapshot timestamp, why is that? And is the returned propagated timestamp set to the snapshot timestamp of the scan? -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 17:17:09 +0000 Gerrit-HasComments: Yes
