Hello Will Berkeley, Andrew Wong, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8891
to review the following change.
Change subject: Improve scans dashboard
......................................................................
Improve scans dashboard
* Adds a ring buffer to the scanners manager which holds historical scan
details, so that the scan dashboard can show recently completed scans.
The size of the buffer is configurable with a new experimental flag,
--scan-history-count which defaults to 20. A new 'state' column has
been added to indicate the state of the scan (active, expired, failed,
or complete).
* Mustache-ifies the scans dashboard.
* The dashboard previously showed raw values, with pretty-printed values
as a tooltip. In order to match the maintenance manager dashboard,
these have been swapped so that pretty-printed values are more
prominent.
* Adds a new pseudo-SQL query description column, replacing the
predicates columns. This allows the table, projected columns, and
optimized predicates to be shown in a very concise way. Previously the
table name and projected columns weren't exposed at all.
* Removes 'from disk' from statistics names, since it was misleading, or
downright wrong. The tooltip for the cells, bytes, and cblocks read
columns now indicates that the values could have been read from cache or
from disk. It would probably be nice to add a cache hit rate to the
stats, but I didn't want to include it in this commit as it's already
big.
* Adds aggregated totals for scan stats.
* A bunch of other polish, like tooltip descriptions of the
non-completely-obvious column headers, and adding a link from the
tablet ID to the replica's page.
Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a
example: https://i.imgur.com/WLMK263.png
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/iterator_stats.cc
M src/kudu/common/iterator_stats.h
M src/kudu/common/scan_spec-test.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
A www/scans.mustache
15 files changed, 448 insertions(+), 219 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/8891/1
--
To view, visit http://gerrit.cloudera.org:8080/8891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a
Gerrit-Change-Number: 8891
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
