Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8891 )
Change subject: Improve scans dashboard ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tablet/cfile_set-test.cc File src/kudu/tablet/cfile_set-test.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tablet/cfile_set-test.cc@319 PS2, Line 319: EXPECT_EQ(stats[0].cblocks_read, 1); : EXPECT_EQ(stats[1].cblocks_read, 1); : EXPECT_EQ(stats[2].cblocks_read, 1); > nit (since the change list touches these lines): the expected value comes f Done -- To view, visit http://gerrit.cloudera.org:8080/8891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a Gerrit-Change-Number: 8891 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 20:19:44 +0000 Gerrit-HasComments: Yes
