Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8891 )
Change subject: Improve scans dashboard ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.cc@164 PS1, Line 164: anDe > const auto&? The type here is an iterator, so it's a local. http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.cc@282 PS2, Line 282: % > Mod is division is expensive and this is under lock, and we'd be modding ev I was hoping the optimizer would figure this out, since the addition is by 1, but apparently not: https://godbolt.org/g/Er2Xhz. Fixed! -- To view, visit http://gerrit.cloudera.org:8080/8891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a Gerrit-Change-Number: 8891 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 19:13:06 +0000 Gerrit-HasComments: Yes
