Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8891 )
Change subject: Improve scans dashboard ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/common/iterator_stats.cc File src/kudu/common/iterator_stats.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/common/iterator_stats.cc@40 PS2, Line 40: void IteratorStats::AddStats(const IteratorStats& other) { : cells_read += other.cells_read; : bytes_read += other.bytes_read; : cblocks_read += other.cblocks_read; : DCheckNonNegative(); : } : : void IteratorStats::SubtractStats(const IteratorStats& other) { : cells_read -= other.cells_read; : bytes_read -= other.bytes_read; : cblocks_read -= other.cblocks_read; : DCheckNonNegative(); : } > syntactic sugar nit: these might be operator -= and operator +=; members of Done http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.h@104 PS2, Line 104: std::vector<ScanDescriptor> ListScans(); > nit: const? Done http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/tserver_path_handlers.cc@571 PS2, Line 571: > nit: re-use 'now' from line 563 ? good catch. -- To view, visit http://gerrit.cloudera.org:8080/8891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a Gerrit-Change-Number: 8891 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 20:17:47 +0000 Gerrit-HasComments: Yes
