Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8891 )
Change subject: Improve scans dashboard ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/common/iterator_stats.cc File src/kudu/common/iterator_stats.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/common/iterator_stats.cc@40 PS2, Line 40: void IteratorStats::AddStats(const IteratorStats& other) { : cells_read += other.cells_read; : bytes_read += other.bytes_read; : cblocks_read += other.cblocks_read; : DCheckNonNegative(); : } : : void IteratorStats::SubtractStats(const IteratorStats& other) { : cells_read -= other.cells_read; : bytes_read -= other.bytes_read; : cblocks_read -= other.cblocks_read; : DCheckNonNegative(); : } syntactic sugar nit: these might be operator -= and operator +=; members of the IteratorStats class or friend functions. http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tablet/cfile_set-test.cc File src/kudu/tablet/cfile_set-test.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tablet/cfile_set-test.cc@319 PS2, Line 319: EXPECT_EQ(stats[0].cblocks_read, 1); : EXPECT_EQ(stats[1].cblocks_read, 1); : EXPECT_EQ(stats[2].cblocks_read, 1); nit (since the change list touches these lines): the expected value comes first. Also, while you are at it, maybe add ASSERT_GE(stats.size(), 3) check prior to accessing 'stats' elements. http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.h@104 PS2, Line 104: std::vector<ScanDescriptor> ListScans(); nit: const? http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/tserver_path_handlers.cc@571 PS2, Line 571: nit: re-use 'now' from line 563 ? -- To view, visit http://gerrit.cloudera.org:8080/8891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a Gerrit-Change-Number: 8891 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 19:27:47 +0000 Gerrit-HasComments: Yes
