Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8891 )
Change subject: Improve scans dashboard ...................................................................... Patch Set 2: (4 comments) The build failure seems to point to a race with descriptors. http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: PS1: Good riddance. http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.h@146 PS1, Line 146: nit: scans. http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8891/1/src/kudu/tserver/scanners.cc@164 PS1, Line 164: anDe const auto&? http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8891/2/src/kudu/tserver/scanners.cc@282 PS2, Line 282: % Mod is division is expensive and this is under lock, and we'd be modding every completed scan after the buffer fills up. Maybe branch instead of mod? I suppose this isn't really a hotpath and this version is probably the easier on the eyes, so up to you. -- To view, visit http://gerrit.cloudera.org:8080/8891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbdee00d8a343fd3728c6ec8ee252d64d0e416a Gerrit-Change-Number: 8891 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 06:56:56 +0000 Gerrit-HasComments: Yes
