Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@237 PS10, Line 237: READ_YOUR_WRITES = 3; > It may be good to add docs about whether a snapshot timestamp and propagate Will update. We do not return the chosen snapshot timestamp, because as we discussed offline, for multi tablet scan we should not reuse the timestamps across servers in this mode. Each server should be free to choose a timestamp as long as it respects the aforementioned condition (This is documented in the design doc as well :)). The returned propagated timestamp is set to 'Now' of the tserver (same as other scan mode). However, as discussed the client should only update the propagated timestamp after the scan of last tablet for multi tablet scan. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2018 22:49:01 +0000 Gerrit-HasComments: Yes
