David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 10: (11 comments) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@222 PS10, Line 222: snapshot nit: snapshot timestamp http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@228 PS10, Line 228: take nit: choose http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/common/common.proto@229 PS10, Line 229: which nit: such that http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1922 PS10, Line 1922: TestScanYourWrites We decided we also wanted scan your reads right? is that covered? http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1944 PS10, Line 1944: // Send the call I know this is likely copy/paste but remove (adds nothing) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1953 PS10, Line 1953: // Make sure that there is no snapshot timestamp sent back. : ASSERT_TRUE(!resp.has_snap_timestamp()); I'm still unsure why we wouldn't the response to include the timestamp. I agree that the scan itself (seen as a collection os scans to multiple tablets) can't be described by a single timestamp, but having the timestamp in the response would allows to have fault-tolerant scans, right? http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1989 PS10, Line 1989: // Send the call same http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.h@158 PS10, Line 158: on the read mode, on the read mode? http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.cc@2107 PS10, Line 2107: s.IsNotSupported() nit add a predict false http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.cc@2161 PS10, Line 2161: 0 use kMinTimestamp or something? I understand you can't use kInvalidTimestamp (it's big) but don't want to accidentally set time to 0 (been there done that :)) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_service.cc@2163 PS10, Line 2163: tmp_snap_timestamp > clean_timestamp ? : tmp_snap_timestamp : clean_timestamp; std:max ? -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2018 22:33:39 +0000 Gerrit-HasComments: Yes
