Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/10114/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10114/3//COMMIT_MSG@9 PS3, Line 9: This uses the C preprocessor to check the value of KUDU_INT128_SUPPORTED from the C++ headers > Should probably add the bit about config.pxi and how it works. Done http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/client.pyx@2499 PS3, Line 2499: check_status(self.row.SetUnixTimeMicros(i, <int64_t> > Still outstanding? Done http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/client.pyx@2499 PS3, Line 2499: check_status(self.row.SetUnixTimeMicros(i, <int64_t> > Nit: remove blank line Done http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/config.pxi.in File python/kudu/config.pxi.in: http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/config.pxi.in@18 PS3, Line 18: // This file is processed by setup.py : // See generate_config_pxi. > Nit: config.pxi is intended to be semi-generic going forward, so perhaps th Done http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py@90 PS2, Line 90: src = os.path.join(setup_dir, 'kudu/config.pxi.in') > Why "cc -x c++" and not "c++"? Thing is we probably want to honor the CC/CX Done http://gerrit.cloudera.org:8080/#/c/10114/4/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/4/python/setup.py@70 PS4, Line 70: for x in ['kudu/client.cpp', > Nit: alphabetic sorting? Done http://gerrit.cloudera.org:8080/#/c/10114/4/python/setup.py@93 PS4, Line 93: cc = os.getenv("CXX","cc") > CXX refers to C++ but 'cc' is the C compiler. So either 'cc' should be 'c++ Done -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 21:07:43 +0000 Gerrit-HasComments: Yes
