Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10114/5/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10114/5/python/kudu/client.pyx@1338 PS5, Line 1338: raise KuduException("The decimal type is not supported when GGC version is < 4.6.0"%self) Nit: raise Foo("..." % self) (note the spaces surrounding the percent sign) http://gerrit.cloudera.org:8080/#/c/10114/5/python/kudu/client.pyx@2504 PS5, Line 2504: raise KuduException("The decimal type is not supported when GGC version is < 4.6.0"%self) Same here. http://gerrit.cloudera.org:8080/#/c/10114/5/python/kudu/schema.pyx File python/kudu/schema.pyx: http://gerrit.cloudera.org:8080/#/c/10114/5/python/kudu/schema.pyx@772 PS5, Line 772: raise RuntimeError("The decimal type is not supported when GGC version is < 4.6.0"%self) Nit: why RuntimeError here and not KuduException? Also note the spaces around the percent sign here. http://gerrit.cloudera.org:8080/#/c/10114/5/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/5/python/setup.py@27 PS5, Line 27: import distutils.ccompiler Unused? -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 21:14:24 +0000 Gerrit-HasComments: Yes
