Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10574 )
Change subject: [java] Add equals and hashcode to Schema ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@297 PS1, Line 297: > All the other fields are derived from the list of columns passed to the con What about columnsById? You can have two schemas, one with IDs and one without, and they shouldn't be identical, right? As an aside, this kind of discussion is exactly why I prefer really dumb equals/hashCode impls that just consider every field. Why bother debating whether to include/exclude a field and risk getting it wrong? Granted, there are exceptions (such as when the class interacts with an ORM), but it works pretty well in the common case. -- To view, visit http://gerrit.cloudera.org:8080/10574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c Gerrit-Change-Number: 10574 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 01 Jun 2018 18:13:04 +0000 Gerrit-HasComments: Yes
