Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10574 )
Change subject: [java] Add equals and hashcode to Schema ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@297 PS1, Line 297: > What about columnsById? You can have two schemas, one with IDs and one with columsById isn't a part of the public API and we can't reasonably expect users to know how to use it or set it when making "equivalent schemas". If we included columsById which are a server side detail best I can tell, a user won't be able to validate a user created schema with one returned from an openTable request using the equals method. I agree dump equals methods are the best approach. But I think that dumb constructors are a pre-requisite. It seams like the ideal approach is to push column ids as far back as possible (to the protobuf helper) and eliminate column ids from the apis. -- To view, visit http://gerrit.cloudera.org:8080/10574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c Gerrit-Change-Number: 10574 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sun, 03 Jun 2018 21:18:18 +0000 Gerrit-HasComments: Yes
