Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10574 )
Change subject: [java] Add equals and hashcode to Schema ...................................................................... Patch Set 4: Schema and ColumnSchema are a bit unique in that there are multiple definitions of equality that could apply to them in different situations. For instance, it may be useful to be able to create a schema with column names and types, and compare that to the schema of an opened table to determine if rows can be written to it. Or a different situation is the backup tool where exact equality is required including column IDs and column attributes. Given that there are different requirements in different situations, I think it would be good to not change the current semantics of .equals, and instead provide methods on Schema which provide the new equality strategy and a more descriptive name and comments. This also neatly sidesteps having to provide a .hashCode method, which I think should be avoided. -- To view, visit http://gerrit.cloudera.org:8080/10574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c Gerrit-Change-Number: 10574 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 05 Jun 2018 17:12:26 +0000 Gerrit-HasComments: No
