Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10574 )
Change subject: [java] Add equals and hashcode to Schema ...................................................................... Patch Set 4: > it may be useful to be able to create a schema with column names and types, > and compare that to the schema of an opened table to determine if rows can be > written to it. I view this as compatibility not equality. > Or a different situation is the backup tool where exact equality is required > including column IDs and column attributes. Why are columnIDs important in a backup tool? I think I need to look into these ids more. > This also neatly sidesteps having to provide a .hashCode method, which I > think should be avoided. Why should it be avoided? -- To view, visit http://gerrit.cloudera.org:8080/10574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c Gerrit-Change-Number: 10574 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 05 Jun 2018 17:17:34 +0000 Gerrit-HasComments: No
