Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10574
to look at the new patch set (#4).
Change subject: [java] Add equals and hashcode to Schema
......................................................................
[java] Add equals and hashcode to Schema
Adds an equals and hashcode method to Schema
and PartitionSchema. Additionally fixes the equality
check on ColumnSchema to consider column attributes.
These methods are useul to quickly know that two
Schemas are exactly the same. We will use them in
the backup and restore testing, and they are likely
more useful than reference equality to users.
A few light tests were added to prove equality works.
Exhaustive testing was not done given that would be
a large amount of tests and the implementation is fairly
straightforward using Guava.
Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
A java/kudu-client/src/test/java/org/apache/kudu/TestSchema.java
5 files changed, 175 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/10574/4
--
To view, visit http://gerrit.cloudera.org:8080/10574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c
Gerrit-Change-Number: 10574
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins