Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10574 )
Change subject: [java] Add equals and hashcode to Schema ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10574/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@297 PS1, Line 297: > columsById isn't a part of the public API and we can't reasonably expect us On the flip side, excluding columnsById means that a schema constructed with column IDs using the non-stable API will be equal to a schema constructed normally without column IDs. I'll grant you that this is a rarer edge case than the one you've described, but it's still something we should address. Agreed that eliminating column IDs from these APIs would be the way to go. -- To view, visit http://gerrit.cloudera.org:8080/10574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6914b9b25df9e327ed6ae6bd61eac29c9c524c Gerrit-Change-Number: 10574 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 05 Jun 2018 16:40:10 +0000 Gerrit-HasComments: Yes
