Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11176 )

Change subject: [build] Move default sanitizer options into build from shell 
scripts
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh@176
PS7, Line 176: # Sanitizer suppressions require symbolization.
> Does this work? Don't PATH entries need to be directories?
No it doesn't..which is why the tsan build failed. This was a late night edit 
just so I could kick off a build and see in the morning.


http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh@180
PS7, Line 180: export 
PATH=$(pwd)/thirdparty/installed/uninstrumented/bin/llvm-symbolizer:$PATH
> So the downside of placing this here is that we don't get it if we run Java
I will do some manual testing today and see what I can come up with. If I can't 
resolve this we are no worse off than we were before.



--
To view, visit http://gerrit.cloudera.org:8080/11176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645
Gerrit-Change-Number: 11176
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 21 Aug 2018 15:24:41 +0000
Gerrit-HasComments: Yes

Reply via email to