Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 7: (3 comments) The past few runs have been failing in TSAN in the same way. I suspect the suppressions (or maybe all of the options) aren't getting through. http://gerrit.cloudera.org:8080/#/c/11176/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11176/7//COMMIT_MSG@17 PS7, Line 17: The only option that was not provided at build time is : the external_symbolizer_path. Instead the : llvm_symbolizer from thirdparty is added to the PATH : so it can be found if no custom : external_symbolizer_path is provided. Please explain why this deviation was necessary. http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh@176 PS7, Line 176: # Sanitizer suppressions require symbolization. Does this work? Don't PATH entries need to be directories? $ PATH=~/Source/kudu/thirdparty/installed/uninstrumented/bin/llvm-symbolizer:$PATH; llvm-symbolizer --version Command 'llvm-symbolizer' not found, but can be installed with: sudo apt install llvm $ PATH=~/Source/kudu/thirdparty/installed/uninstrumented/bin:$PATH; llvm-symbolizer --version LLVM (http://llvm.org/): LLVM version 6.0.0 Optimized build. Default target: x86_64-unknown-linux-gnu Host CPU: skylake http://gerrit.cloudera.org:8080/#/c/11176/7/build-support/jenkins/build-and-test.sh@180 PS7, Line 180: export PATH=$(pwd)/thirdparty/installed/uninstrumented/bin/llvm-symbolizer:$PATH So the downside of placing this here is that we don't get it if we run Java tests locally, or via an IDE, or basically in any other way that doesn't go through build-and-test.sh and doesn't use dist-test. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 21 Aug 2018 04:28:29 +0000 Gerrit-HasComments: Yes