Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12348 )
Change subject: [docker] Fix bootstrap-env.sh for some OS versions ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG@12 PS3, Line 12: - Fixes cases where `which` isn’t installed. Seriously? Where did you see this happen? http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@44 PS3, Line 44: python -m pip install "pip install ..." doesn't work? http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@54 PS3, Line 54: if [[ -f "/usr/bin/yum" ]]; then -x would be more precise (since you're going to execute the thing). Below too. http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@125 PS3, Line 125: --no-install-recommends Isn't the default behavior to not install recommended packages, but only required packages? -- To view, visit http://gerrit.cloudera.org:8080/12348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2894562c507d753bee5880947edfb917fd01fcb Gerrit-Change-Number: 12348 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 04:37:07 +0000 Gerrit-HasComments: Yes
