Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12348 )
Change subject: [docker] Fix bootstrap-env.sh for some OS versions ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh@28 PS4, Line 28: function install_python_packages() { Would be good to doc why we're using get-pip.py and not the python-pip system package. http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh@38 PS4, Line 38: pip 19.1 doesn't support Python 3.4, : # which is the version of Python 3 shipped with Ubuntu 14.04. Shouldn't we use https://bootstrap.pypa.io/3.3/ for the Ubuntu 14 case? Something like: if 2.6; then curl 2.6/get-pip.py | python else if 3.3; then curl 3.3/get-pip.py | python3 else curl get-pip.py | python -- To view, visit http://gerrit.cloudera.org:8080/12348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2894562c507d753bee5880947edfb917fd01fcb Gerrit-Change-Number: 12348 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 20:36:08 +0000 Gerrit-HasComments: Yes
