Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12348 )
Change subject: [docker] Fix bootstrap-env.sh for some OS versions ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG@12 PS3, Line 12: - Fixes cases where `which` isn’t installed. > Centos 7: Wow. That must be an incredibly minimal base OS installation. http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG@15 PS3, Line 15: - Adds the ntp service for centos. > I agree this may not be required. Can we leave it in for now and I will rem Yeah I don't mind keeping it in until we better understand what to do here. http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@44 PS3, Line 44: python -m pip install > No it doesn't I learned via experience what works but didn't get to a point Thanks for the link. The comment thread points out that what we're doing (installing pip from system packages then upgrading it from pypi) is a bad idea that is likely to burn us. Buried in the comment thread is a useful comment that describes a safe way to bootstrap pip outside of system packages: use get-pip.py. I remember doing this before and I think it's a good idea here. Basically, rather than installing python-pip or whatever system package, use curl/wget to fetch get-pip.py and run it as root; this will install pip for everyone to use. See https://github.com/pypa/get-pip for details. http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@125 PS3, Line 125: --no-install-recommends > The default is to install recommended packages: TIL. -- To view, visit http://gerrit.cloudera.org:8080/12348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2894562c507d753bee5880947edfb917fd01fcb Gerrit-Change-Number: 12348 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 06:00:48 +0000 Gerrit-HasComments: Yes
