Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12348 )
Change subject: [docker] Fix bootstrap-env.sh for some OS versions ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG@12 PS3, Line 12: - Fixes cases where `which` isn’t installed. > Seriously? Where did you see this happen? Centos 7: docker run -it --rm centos:7 /bin/bash [root@9d4262611c2c /]# which bash: which: command not found http://gerrit.cloudera.org:8080/#/c/12348/3//COMMIT_MSG@15 PS3, Line 15: - Adds the ntp service for centos. > As Todd mentioned on Slack, this probably isn't going to work because time I agree this may not be required. Can we leave it in for now and I will remove it in a patch that fixes `use_hybrid_clock=true` / ntp once the solution is vetted? There are examples where you can use ntp in a docker image with special capabilities: https://github.com/cturra/docker-ntp http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@44 PS3, Line 44: python -m pip install > "pip install ..." doesn't work? No it doesn't I learned via experience what works but didn't get to a point of full understanding. This thread is relevant: https://github.com/pypa/pip/issues/5221#issuecomment-382069604 http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@54 PS3, Line 54: if [[ -f "/usr/bin/yum" ]]; then > -x would be more precise (since you're going to execute the thing). Below t Fair, but I will let that fail later, otherwise it will just say unsupported OS. http://gerrit.cloudera.org:8080/#/c/12348/3/docker/bootstrap-env.sh@125 PS3, Line 125: --no-install-recommends > Isn't the default behavior to not install recommended packages, but only re The default is to install recommended packages: https://unix.stackexchange.com/questions/77053/apt-installing-more-packages-than-specified-as-dependencies/77076#77076 Setting this flag is a very common practice in docker where images size is important. -- To view, visit http://gerrit.cloudera.org:8080/12348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2894562c507d753bee5880947edfb917fd01fcb Gerrit-Change-Number: 12348 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 05:14:32 +0000 Gerrit-HasComments: Yes
