Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12348 )
Change subject: [docker] Fix bootstrap-env.sh for some OS versions ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh@28 PS4, Line 28: function install_python_packages() { > Would be good to doc why we're using get-pip.py and not the python-pip syst Done http://gerrit.cloudera.org:8080/#/c/12348/4/docker/bootstrap-env.sh@38 PS4, Line 38: : setuptools_scm > Shouldn't we use https://bootstrap.pypa.io/3.3/ for the Ubuntu 14 case? Som Ubuntu 14 uses python 2.7 by default. 3.3/get-pip.py installs pip 10.0.1 which is lower than we need. There is no 3.4 url that picks < 19.0. Using <19.0 ensures we support both 2.7 and 3.x versions we need. -- To view, visit http://gerrit.cloudera.org:8080/12348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2894562c507d753bee5880947edfb917fd01fcb Gerrit-Change-Number: 12348 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 20:47:19 +0000 Gerrit-HasComments: Yes
