Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc@97 PS3, Line 97: matches[4].rm_eo - (matches[4].rm_s > Hmm, no. I'm surprised UBSAN didn't complain about undefined behavior. Seems like substr() should take care of that for us: If the requested substring extends past the end of the string, or if count == npos, the returned substring is [pos, size()). -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 00:18:36 +0000 Gerrit-HasComments: Yes
