Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 3: > (1 comment) > > > It doesn't need to be done in this change, but at some point it > might be a good idea to decouple version as in artifact version.txt > type version and feature flag x things is supported version. > > > > Currently we use the version in `VersionSupportsRF1Movement`, If > instead we checked in a version epoch of sorts we could decouple > these two concepts and avoid weird issues. > > I think the issue here was that, at the time that VersionSupportsRF1Movement > was added, we wanted it to be retroactively true for several > releases of Kudu. A feature flag can't address that: it'll only > give you "supports X"=true from the release that added the flag > rather than a release or two before then. > > Alexey would know more about it. Adar is right: VersionSupportsRF1Movement() was introduced because it was not possible to use feature flags to deal with a bug discovered later on when a few versions have been already released. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 00:30:34 +0000 Gerrit-HasComments: No
