Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 5: (1 comment) > It doesn't need to be done in this change, but at some point it might be a > good idea to decouple version as in artifact version.txt type version and > feature flag x things is supported version. > > Currently we use the version in `VersionSupportsRF1Movement`, If instead we > checked in a version epoch of sorts we could decouple these two concepts and > avoid weird issues. I think the issue here was that, at the time that VersionSupportsRF1Movement was added, we wanted it to be retroactively true for several releases of Kudu. A feature flag can't address that: it'll only give you "supports X"=true from the release that added the flag rather than a release or two before then. Alexey would know more about it. http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc@97 PS3, Line 97: matches[4].rm_eo - (matches[4].rm_s > nit: I don't think it matters because we're at the end of the string anyway Hmm, no. I'm surprised UBSAN didn't complain about undefined behavior. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 00:15:04 +0000 Gerrit-HasComments: Yes
